Use commonjs syntax for exports#63
Open
chriddell wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR converts the theme module from ES Module (ESM) export syntax to CommonJS export syntax to improve compatibility with older Node.js versions that don't natively support ESM imports.
- Changed from
export const theme = {...}tomodule.exports = { theme: {...} } - Wrapped the existing theme object as a property of the exported object
- Added proper closing brace to maintain the nested structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rcantin-w
requested review from
davidpmccormick
and removed request for
rcantin-w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Use the
module.exports(commonjs) syntax instead ofexport(ESM) syntax. This prevents confusion when importing the package in projects using older versions of Node which don't natively support ESM.e.g.
How to test
You could use
npm linkto link the package locally, and make sure it still works in your project. I've done this, and it does!https://dev.to/erinbush/npm-linking-and-unlinking-2h1g
How can we measure success?
Have we considered potential risks?