chore: remove dead types and un-export internal query aliases#105
Merged
chore: remove dead types and un-export internal query aliases#105
Conversation
These utility types were never used anywhere in the library or in downstream consumers (epicenter). Users can achieve the same with TypeScript's built-in Extract<> if needed.
This type combining StandardSchemaV1 and StandardJSONSchemaV1 was exported but never used in the library or any downstream consumers. Users can intersect the two types themselves if needed.
DefineQueryInput, DefineQueryOutput, DefineMutationInput, and DefineMutationOutput are implementation details used only within createQueryFactories. No consumer ever imports them by name — they were already excluded from the public barrel export in index.ts.
braden-w
force-pushed
the
braden-w/remove-dead-types-clean
branch
from
f923c4c to
a38bc4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused exported types and un-exports internal type aliases that were never meant to be part of the public API. This shrinks the public surface area and trims ~370 lines of verbose JSDoc that was duplicating information already visible in the code.
Three categories of cleanup:
ExtractOkFromResult,ExtractErrFromResult(result),StandardFullSchemaV1(standard-schema) — zero usage across the codebaseDefineQueryInput,DefineQueryOutput,DefineMutationInput,DefineMutationOutput— these were implementation details ofcreateQueryFactories, not consumer-facing. Type definitions inlined at their single usage site.The query module's JSDoc was also trimmed from tutorial-style documentation to concise single-line summaries. The verbose docs were adding noise without value — the types and code examples in the
createQueryFactoriesdocstring already communicate usage clearly.