Integrate Transfer Guard program into WNS #107
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kespinola
suggested changes
Jun 25, 2024
kespinola
changed the title
Contributor
|
This branch updates WNS to use token group from token extension but the TE doesn't support it yet. It needs to be deployed before this can be released. This does not include a migration script for existing collections using the token group shim from WNS. |
kespinola
suggested changes
Jul 17, 2024
Contributor
kespinola
left a comment
kespinola
left a comment
There was a problem hiding this comment.
This should fix up the dependency issue.
| .additional_metadata | ||
| .iter() | ||
| .find(|(key, _)| key == ROYALTY_BASIS_POINTS_FIELD) | ||
| .map(|(_, value)| u64::from_str(value).unwrap()) |
Contributor
There was a problem hiding this comment.
Suggested change
| .map(|(_, value)| u64::from_str(value).unwrap()) | |
| .map(|(_, value)| u64::from_str(value))? |
maybe not quite this but should be able to handle the result without unwrap
| wen_royalty_distribution.workspace = true | ||
| spl-transfer-hook-interface.workspace = true | ||
| spl-tlv-account-resolution.workspace = true | ||
| spl-type-length-value.workspace = true |
Contributor
There was a problem hiding this comment.
Suggested change
| spl-type-length-value.workspace = true | |
| spl-type-length-value.workspace = true | |
| wen-royalties-interface.workspace = true |
| @@ -0,0 +1,12 @@ | |||
| [package] | |||
| name = "royalties-interface" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| name = "royalties-interface" | |
| name = "wen-royalties-interface" |
Comment on lines
+3
to
+4
| version = "0.1.0" | ||
| edition = "2021" |
Contributor
There was a problem hiding this comment.
Suggested change
| version = "0.1.0" | |
| edition = "2021" | |
| version.workspace = true | |
| edition.workspace = true | |
| repository.workspace = true | |
| publish.workspace = true |
Comment on lines
+16
to
+19
| spl-transfer-hook-interface = "0.6.5" | ||
| spl-tlv-account-resolution = "0.6.5" | ||
| spl-pod = "0.2.5" | ||
| spl-type-length-value = "=0.3.0" |
Contributor
There was a problem hiding this comment.
Suggested change
| spl-transfer-hook-interface = "0.6.5" | |
| spl-tlv-account-resolution = "0.6.5" | |
| spl-pod = "0.2.5" | |
| spl-type-length-value = "=0.3.0" | |
| spl-transfer-hook-interface = "0.6.5" | |
| spl-tlv-account-resolution = "0.6.5" | |
| spl-pod = "0.2.5" | |
| spl-type-length-value = "=0.3.0" | |
| wen-royalties-interface = { path = "libraries/royalties-interface" } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.