Repository navigation
Upgrade devDependencies to the latest versions, use Node 26 in CI and fix the lint issues - #720
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Regenerate and commit the distributable dist/ artifacts.
Pull request overview
Upgrades development dependencies, moves CI to Node 26, and fixes JavaScript and stylesheet lint issues.
Changes:
- Updates dependencies and lint configuration.
- Uses Node 26 in test and deployment workflows.
- Fixes ESLint and Stylelint findings.
File summaries
| File | Summary |
|---|---|
stylelint.config.js |
Allows legacy color-function syntax. |
src/MultipleSelect.js |
Removes a redundant assignment. |
src/multiple-select.scss |
Applies lint-compliant stylesheet fixes. |
package.json |
Updates dependencies and lint scripts. |
.github/workflows/test.yml |
Uses Node 26 for testing. |
.github/workflows/deploy.yml |
Uses Node 26 for deployment. |
Review details
Suppressed comments (1)
src/multiple-select.scss:8
- The repository publishes
dist/as the compiled CSS/JS (package.json:9-17,site/docs/whats-include.md:25-39), but this source-only change leaves the checked-indist/multiple-select.css,dist/multiple-select.min.css, anddist/multiple-select.jswith the old forms (top: 0px,:before,Alpha(...), andlet selected = false). Please regenerate and commit the distributable artifacts so the published package stays synchronized withsrc/.
/* Keep the deprecated `clip` instead of `clip-path` for older browsers */
/* stylelint-disable-next-line property-no-deprecated */
clip: rect(0 0 0 0)!important;
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades all devDependencies to the latest versions and bumps CI to Node 26. Details per commit:
1. Upgrade devDependencies to the latest versions and use Node 26 in CI
eslint9 → 10,@babel/core/@babel/eslint-parser7 → 8,editorconfig-checker6 → 7,npm-run-all28 → 9, plus the remaining minor/patch updates (vite8.1 → 8.3,vue3.5.39 → 3.5.42,@vitejs/plugin-vue,sass,stylelint,rollup,cspell,globals).@eslint/jsexplicitly:eslint.config.jsimports it, but it was only available through a transitive dependency.@babel/preset-envandcore-js: the repo has no babel config and nothing references either of them.test.yml,deploy.yml):node-version22 → 26.editorconfig-checker@7requires Node >= 24.14 andnpm-run-all2@9requires >= 22.22.2, and yarn v1 aborts the install on an engines mismatch.@rollup/plugin-babel@7.1.0still peers@babel/core@^7andeslint-plugin-import@2.32.0still peerseslint@^9. Both are already the latest releases and both work with the new versions — the rollup/babel build output is byte-identical to the Babel 7 one, and theeslint-plugin-importrules run correctly on ESLint 10.2. Fix the no-useless-assignment error reported by ESLint 10
setSelects()initialisedselectedwithfalse, but every branch overwrites it before the first read. ESLint 10 enablesno-useless-assignmentineslint:recommended.3. Lint the main stylesheet and fix the reported style issues
lint:cssused an unquotedsrc/**/*.scss. The shell expanded it tosrc/themes/bootstrap.scssonly (insh,**behaves like*), sosrc/multiple-select.scsswas never linted. Quoting the pattern lets stylelint match both files.top: 0px→0,:before→::before, redundant border/paddingshorthand values, empty-line formatting, andfilter: Alpha(Opacity = 35)→filter: alpha(opacity = 35).clipin.ms-offscreen— classic offscreen pattern,clip-pathis not supported by the browsers this project targets, so the declaration has an inlinestylelint-disable-next-lineplus a comment.rgba()alpha syntax —color-function-alias-notationis disabled instylelint.config.js(next to the already disabledcolor-function-notationandalpha-value-notation) because IE10/11 only understandrgba().Verification
yarn install --frozen-lockfilepasses (the CI install path).yarn lintpasses: eslint, stylelint (now covering both stylesheets, verified via--formatter json), cspell and editorconfig-checker.js:build:base|min|vueandcss:build:scss|base|min|banner.