Skip to content

Upgrade devDependencies to the latest versions, use Node 26 in CI and fix the lint issues - #720

Merged
wenzhixin merged 3 commits into
developfrom
feature/upgrade-dev-dependencies
Sep 16, 2026
Merged

wenzhixin merged 3 commits into
developfrom
feature/upgrade-dev-dependencies

Conversation

@wenzhixin

Copy link
Copy Markdown
Owner

Upgrades all devDependencies to the latest versions and bumps CI to Node 26. Details per commit:

1. Upgrade devDependencies to the latest versions and use Node 26 in CI

  • eslint 9 → 10, @babel/core / @babel/eslint-parser 7 → 8, editorconfig-checker 6 → 7, npm-run-all2 8 → 9, plus the remaining minor/patch updates (vite 8.1 → 8.3, vue 3.5.39 → 3.5.42, @vitejs/plugin-vue, sass, stylelint, rollup, cspell, globals).
  • Declare @eslint/js explicitly: eslint.config.js imports it, but it was only available through a transitive dependency.
  • Drop the unused @babel/preset-env and core-js: the repo has no babel config and nothing references either of them.
  • CI (test.yml, deploy.yml): node-version 22 → 26. editorconfig-checker@7 requires Node >= 24.14 and npm-run-all2@9 requires >= 22.22.2, and yarn v1 aborts the install on an engines mismatch.
  • Two peer warnings remain on install (yarn v1 only warns, it does not fail): @rollup/plugin-babel@7.1.0 still peers @babel/core@^7 and eslint-plugin-import@2.32.0 still peers eslint@^9. Both are already the latest releases and both work with the new versions — the rollup/babel build output is byte-identical to the Babel 7 one, and the eslint-plugin-import rules run correctly on ESLint 10.

2. Fix the no-useless-assignment error reported by ESLint 10

setSelects() initialised selected with false, but every branch overwrites it before the first read. ESLint 10 enables no-useless-assignment in eslint:recommended.

3. Lint the main stylesheet and fix the reported style issues

  • lint:css used an unquoted src/**/*.scss. The shell expanded it to src/themes/bootstrap.scss only (in sh, ** behaves like *), so src/multiple-select.scss was never linted. Quoting the pattern lets stylelint match both files.
  • Fixed the issues this surfaced: top: 0px → 0, :before → ::before, redundant border/padding shorthand values, empty-line formatting, and filter: Alpha(Opacity = 35) → filter: alpha(opacity = 35).
  • Two items kept as they are, on purpose:
    • clip in .ms-offscreen — classic offscreen pattern, clip-path is not supported by the browsers this project targets, so the declaration has an inline stylelint-disable-next-line plus a comment.
    • the legacy rgba() alpha syntax — color-function-alias-notation is disabled in stylelint.config.js (next to the already disabled color-function-notation and alpha-value-notation) because IE10/11 only understand rgba().

Verification

  • yarn install --frozen-lockfile passes (the CI install path).
  • yarn lint passes: eslint, stylelint (now covering both stylesheets, verified via --formatter json), cspell and editorconfig-checker.
  • The full build chain passes on Node 26: js:build:base|min|vue and css:build:scss|base|min|banner.
  • The CSS generated from the updated stylesheet was diffed against the previous output: only the equivalent rewrites above plus the explanatory comment, no semantic change.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Regenerate and commit the distributable dist/ artifacts.

Pull request overview

Upgrades development dependencies, moves CI to Node 26, and fixes JavaScript and stylesheet lint issues.

Changes:

  • Updates dependencies and lint configuration.
  • Uses Node 26 in test and deployment workflows.
  • Fixes ESLint and Stylelint findings.
File summaries
File Summary
stylelint.config.js Allows legacy color-function syntax.
src/MultipleSelect.js Removes a redundant assignment.
src/multiple-select.scss Applies lint-compliant stylesheet fixes.
package.json Updates dependencies and lint scripts.
.github/workflows/test.yml Uses Node 26 for testing.
.github/workflows/deploy.yml Uses Node 26 for deployment.
Review details

Suppressed comments (1)

src/multiple-select.scss:8

  • The repository publishes dist/ as the compiled CSS/JS (package.json:9-17, site/docs/whats-include.md:25-39), but this source-only change leaves the checked-in dist/multiple-select.css, dist/multiple-select.min.css, and dist/multiple-select.js with the old forms (top: 0px, :before, Alpha(...), and let selected = false). Please regenerate and commit the distributable artifacts so the published package stays synchronized with src/.
  /* Keep the deprecated `clip` instead of `clip-path` for older browsers */
  /* stylelint-disable-next-line property-no-deprecated */
  clip: rect(0 0 0 0)!important;
  • Files reviewed: 6/7 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@wenzhixin
wenzhixin merged commit f8979b8 into develop Sep 16, 2026
2 checks passed
@wenzhixin
wenzhixin deleted the feature/upgrade-dev-dependencies branch September 16, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants