In order to avoid conflicts with other libraries, assigning $ with jQuery#85
Open
jsitarski wants to merge 1 commit intowerein:masterfrom
Open
In order to avoid conflicts with other libraries, assigning $ with jQuery#85jsitarski wants to merge 1 commit intowerein:masterfrom
jsitarski wants to merge 1 commit intowerein:masterfrom
Conversation
…e jQuery namespace.
The coffescripts were compiling with a global use of the $ shortcut which can conflict with other libraries that could be included in an application. By assigning the $ = jQuery, a var will be defined scoped to the function generated by compiling the coffee scripts. This will allow for the functions to use $ internally as jQuery.
For example, if prototype is included, this avoids the two following errors on initialization of the page:
editable_form.js?body=1:5 Uncaught TypeError: Cannot read property 'editableform' of undefined
at editable_form.js?body=1:5
at editable_form.js?body=1:55
and
error_handling.js?body=1:2 Uncaught TypeError: Cannot read property 'editable' of undefined
at error_handling.js?body=1:2
at error_handling.js?body=1:9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rails coffescripts for editable_form and error_handling were compiling with a global use of the $ shortcut which can conflict with other libraries that could be included in an application. By assigning the $ = jQuery, a var will be defined scoped to the function generated by compiling the coffee scripts. This will allow for the functions to use $ internally as jQuery.
For example, if prototype is included, this avoids the two following errors on initialization of the page:
editable_form.js?body=1:5 Uncaught TypeError: Cannot read property 'editableform' of undefined
at editable_form.js?body=1:5
at editable_form.js?body=1:55
and
error_handling.js?body=1:2 Uncaught TypeError: Cannot read property 'editable' of undefined
at error_handling.js?body=1:2
at error_handling.js?body=1:9