Add regex filters to skip specific container log lines. #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ilya-lesikov could you check pls? |
Member
|
@kuzaxak Sorry, didn't get the notification when PR was opened. Looks good, except we don't need any changes in multitracker. It is not used, gonna be deleted in the future, so don't bother. |
Author
Thanks, will update my PR. |
Will be used in nelm with annotation `werf.io/log-regex-skip`. Closes werf#369 Signed-off-by: Vladimir Kuznichenkov <[email protected]>
Author
|
@ilya-lesikov removed multitracker changes |
Member
|
@kuzaxak Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used in nelm with annotation
werf.io/log-regex-skip.The filtering logic for the dynamic readiness tracker differs from the multitracker, which is based on the original implementation. In the multitracker, container-specific regexes mutually exclude global regexes, but in the dynamic readiness, they are applied one on top of the other. I preserved a similar logic for the skip regex. Allow users to use both skip and regular filters to exclude parts of the logs and then filter the results.
Closes #369