Fix emojis for flags, computer and phone names and also add a logo for bsd #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SayakMukhopadhyay
force-pushed
the
fix-flag-emojis
branch
from
d7ec6fb to
e23eb62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding myself (#1929) I noticed that quite a few records don't have an emoji for country and the computer and/or phone are not according to the schema. I am creating this PR to fix all those records with the correct emoji or names.
Additionally, I see that BSD is a valid
computerbut it didn't have a logo so I am adding the BSD logo too.Note
These fixes are needed cause a few PRs were merged without validation checks running. I see that validation checks are not set to automatically run on every PR and thus they aren't running and showing the obvious validation failures.
This can be mitigated either by allowing workflows to run on PRs from contributors or if that is risky (which it can be, since js files are executed), one can make passing status checks mandatory for a PR to be merged
The validation logic is already great and making this small CI change can go a long way in ensuring malformed PRs are caught early.