Skip to content

Fix committing edit category changes with YNAB#17

Merged
wesm merged 2 commits intomainfrom
ynab-fixes
Oct 30, 2025
Merged

Fix committing edit category changes with YNAB#17
wesm merged 2 commits intomainfrom
ynab-fixes

Conversation

@wesm
Copy link
Owner

@wesm wesm commented Oct 30, 2025

No description provided.

wesm and others added 2 commits October 29, 2025 20:19
PutTransactionWrapper.transaction expects ExistingTransaction, not
SaveTransactionWithOptionalFields. The two types have identical fields,
but Pydantic enforces strict type checking.

Changed update_transaction() to create ExistingTransaction instead of
SaveTransactionWithOptionalFields when building the update payload.

Also fixed field name: date -> var_date (correct field name in the model)

Fixes category edit commits in YNAB backend.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Auto-format data_manager.py with ruff
- Fix pyright error in ynab_client.py by using model_validate()
  instead of direct __init__ (pyright doesn't understand Pydantic v2
  __init__ signature properly)

All checks pass: ruff format, ruff check, pyright, pytest

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link

Deploying moneyflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d45421
Status: ✅  Deploy successful!
Preview URL: https://6d371443.moneyflow-6wi.pages.dev
Branch Preview URL: https://ynab-fixes.moneyflow-6wi.pages.dev

View logs

@wesm wesm merged commit a7b2c78 into main Oct 30, 2025
6 checks passed
@wesm wesm deleted the ynab-fixes branch October 30, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant