Conversation
Reduces visual noise by showing currency once in header instead of every cell. Changes: 1. Added get_currency_symbol() to FinanceBackend base class (defaults to "$") 2. YNAB backend fetches currency from budget.currency_format.currency_symbol 3. Monarch/Amazon/Demo backends use default "$" 4. AppController._get_column_config() adds currency_symbol to config dict 5. Formatters extract currency from column_config (DRY, no threading through calls) 6. format_amount() now returns "-1,234.56" instead of "-$1,234.56" 7. Column headers updated to "Total ($)" and "Amount ($)" 8. Created expected_amount() test helper in conftest.py for DRY test assertions 9. Updated all formatter tests to expect new format Implementation: - Currency flows: Backend → column_config → formatters (simple, no refactoring) - YNAB supports €/£/other currencies from API - Monarch defaults to $ (no currency API found) All 895 tests pass, all style checks pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
I created a Euro YNAB plan just to make sure it works: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adjusts some column display widths for better (subjective) readability (eventually these can be made configurable via config.yaml).