Conversation
Previously, pressing 'g' from the detail view (when not drilled down) had no effect, leaving users stuck without an intuitive way to return to aggregate views. This made navigation inconsistent since 'g' works to cycle views in all other contexts. Now 'g' behaves like 'Escape' when in top-level detail view, restoring the previous aggregate view from navigation history (or defaulting to Merchant view). This provides a more intuitive navigation experience where 'g' always helps you change views, and both 'g' and 'Escape' can return you from detail to aggregate view. Changes: - Updated cycle_grouping() in state.py to handle detail view case - Added two comprehensive tests for the new behavior - Updated navigation docs to clarify both keys work from detail view 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The hint bar in top-level detail view now shows "Esc/g=Group" instead of "g=Group" to indicate that both keys can be used to return to an aggregate view. This makes the UI more discoverable and consistent with the behavior added in the previous commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Previously, pressing 'g' to cycle to Category view, then 'd' to detail view, then 'g' or 'Esc' would incorrectly return to Merchant view instead of Category view. This was because switch_to_detail_view() wasn't saving the current aggregate view to navigation history. Also refactored code to eliminate duplication: - Added clear_drill_down_and_selection() helper method in state.py - Replaced 5 instances of duplicated selection-clearing code - Moved NavigationState import to top of file (no inline imports) Changes: - switch_to_detail_view() now saves navigation history from aggregate views - Added clear_drill_down_and_selection() to consolidate repeated code - Added 2 tests for navigation history behavior - All 899 tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
cc @SamEdwardes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21