fix: Display breadcrumb dimensions in drill-down order#29
Merged
Conversation
When drilling into a time period from a subgrouping view (e.g., Merchants > Amazon (by Time) → 2024), the breadcrumb now correctly shows "Merchants > Amazon > 2024" instead of "Time > 2024 > Merchants > Amazon". This makes navigation clearer and ensures Escape key behavior matches the visual hierarchy. Changes: - Added _get_drill_down_order() helper to determine dimension order from navigation history - Refactored get_breadcrumb() to display dimensions in drill-down sequence - Added comprehensive tests for various drill-down scenarios All tests pass (911/911), type checking clean, coverage maintained. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Deploying moneyflow with
|
| Latest commit: |
1d95aca
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7e963310.moneyflow-6wi.pages.dev |
| Branch Preview URL: | https://time-breadcrumb.moneyflow-6wi.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When drilling into a time period from a subgrouping view (e.g., Merchants > Amazon (by Time) → 2024), the breadcrumb now correctly shows "Merchants > Amazon > 2024" instead of "Time > 2024 > Merchants
Changes: