feat: Consolidate screenshot generation into main repo and CI workflow#49
Merged
feat: Consolidate screenshot generation into main repo and CI workflow#49
Conversation
Eliminate moneyflow-assets repository dependency by integrating screenshot generation directly into the GitHub Actions docs deployment workflow. ## Changes ### Infrastructure - Update generate_screenshots.py to output to docs/assets/screenshots/ - Add screenshot generation step to docs.yml workflow (runs on stable push) - Add screenshot verification to bump-version.sh pre-release checks - Simplify post-publish.sh by removing moneyflow-assets logic (-80 lines) - Add docs/assets/screenshots/ to .gitignore (generated fresh in CI) ### Documentation - Update README.md screenshot URL to moneyflow.dev (deployed site) - Update all docs/*.md files to use relative paths (28 references across 5 files) - Update PUBLISHING.md and scripts/README.md to reflect new workflow ## Benefits - Simpler workflow (one repo instead of two) - Automated screenshot generation (no manual steps) - Atomic deployments (screenshots and docs always in sync) - Verifiable releases (screenshot generation tested before version bump) - Cleaner codebase (-80 lines of bash script) ## Testing - Screenshot generation verified locally - All code quality checks passing (ruff, pyright, markdownlint) - Ready for CI testing on stable branch See MIGRATION_SUMMARY.md for complete migration details. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The docs-build-check workflow (runs on main/PRs) needs to generate screenshots before building docs, otherwise mkdocs build fails because docs reference screenshots that don't exist. This mirrors the same screenshot generation step from the docs deployment workflow (docs.yml). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Files in docs/guide/ need to use ../assets/screenshots/ to reference screenshots in docs/assets/screenshots/, not assets/screenshots/. Also fixed broken anchor link in filters.md to match actual heading in navigation.md. This resolves mkdocs --strict build failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate moneyflow-assets repository dependency by integrating screenshot generation directly into the GitHub Actions docs deployment workflow.
Changes
Infrastructure
Documentation
Benefits
Testing
See MIGRATION_SUMMARY.md for complete migration details.
🤖 Generated with Claude Code