fix(cache): Address Review #1580 findings - prevent data loss#66
Merged
Conversation
Review findings addressed: - medium: Remove dangerous save_cache fallback in filtered view when both cache tiers unavailable. In filtered view, data_manager.df only contains the filtered subset, so saving it would overwrite full cache with partial data and lose history. Now just logs error - edits are saved to backend. - low: Strengthen test assertion in test_multiple_sequential_saves to use a known hot cache ID and assert exact final value (EDIT_4) - low: Add test coverage for "both tiers unavailable" path to prevent future regressions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review Findings Addressed
save_cachefallback when both cache tiers unavailable in filtered view. In filtered view,data_manager.dfonly contains the filtered subset, so saving it would overwrite full cache with partial data and lose historical transactions.test_multiple_sequential_saves_persist_correctlyto use a known hot cache ID and assert exact final value (EDIT_4)Test plan
🤖 Generated with Claude Code