Skip to content

refactor: 重构成绩推送逻辑,提升通知触达准确性 - #285

Merged
renbaoshuo merged 1 commit into
masterfrom
refactor/score-notification-key
Sep 6, 2025
Merged

refactor: 重构成绩推送逻辑,提升通知触达准确性#285
renbaoshuo merged 1 commit into
masterfrom
refactor/score-notification-key

Conversation

@renbaoshuo

Copy link
Copy Markdown
Member

@renbaoshuo
renbaoshuo requested a review from klxiaoniu September 1, 2025 08:40
Comment thread lib/notification.ts
@klxiaoniu

Copy link
Copy Markdown
Contributor

apifox上后续要补充上classroom字段

@ozline

ozline commented Sep 1, 2025

Copy link
Copy Markdown
Member

自查一个问题:

旧版本已经开启通知的用户,是否可以在新版本逻辑下不做任何操作继续接收到通知?如果不行的话需要做兼容性处理

@renbaoshuo

Copy link
Copy Markdown
Member Author

自查一个问题:

旧版本已经开启通知的用户,是否可以在新版本逻辑下不做任何操作继续接收到通知?如果不行的话需要做兼容性处理

目前还没有开学,等到期末出成绩缓存早就没了,可以正常收通知。

补考的话,影响面不大

@klxiaoniu

klxiaoniu commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

确实哈,等到期末还在用旧版的用户应该很少了,也可以配合一下强制更新。这个兼容也不是很好做

@ozline

ozline commented Sep 1, 2025

Copy link
Copy Markdown
Member

最后合入的时候标题和描述可以拟人一些,因为这个会直接推送到群内

@renbaoshuo renbaoshuo changed the title refactor: score notification key refactor: 重构成绩推送逻辑,提升通知触达准确性 Sep 1, 2025
@renbaoshuo
renbaoshuo merged commit 58fa412 into master Sep 6, 2025
@renbaoshuo
renbaoshuo deleted the refactor/score-notification-key branch September 6, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants