Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Applies an upstream NativeWind/react-native-css-interop fix to prevent invalid "unspecified" system color scheme values from causing theme switching glitches during AppState transitions.
Changes:
- Add
patch-packageand apostinstallhook to apply dependency patches automatically. - Introduce a patch for
react-native-css-interop@0.2.3to normalize/resolve invalid color scheme values. - Remove the app-level
Appearance.getColorSchememonkey-patch from the theme provider.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
yarn.lock |
Locks new dependencies introduced by patch-package setup. |
patches/react-native-css-interop+0.2.3.patch |
Patches react-native-css-interop to filter/resolve "unspecified" color scheme values. |
package.json |
Adds postinstall script and dev dependencies for patching. |
components/app-theme-provider.tsx |
Removes the global Appearance.getColorScheme override now that dependency patching is introduced. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply patch from nativewind/nativewind#1767
也可以等他们合了发版,不知道等到啥时候