Skip to content

feat(feedback): feat(feedback): add ListFeedback service - #340

Merged
ozline merged 8 commits into
west2-online:mainfrom
wastefi:feedback-api-update
Oct 8, 2025
Merged

feat(feedback): feat(feedback): add ListFeedback service#340
ozline merged 8 commits into
west2-online:mainfrom
wastefi:feedback-api-update

Conversation

@wastefi

@wastefi wastefi commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

feat

这个 PR 做了什么 / 我们为什么需要这个 PR?

目前的福uu受众面相对较大,经常出现用户通过app内的飞书文档反馈bug。然而,飞书文档的反馈无法精准定位用户问题所在,简单的反馈表单无法满足回查所在,因此我们想要有一个内置的反馈系统。
这个pr目前提供了最简单的CreateFeedback与GetFeedback的后端接口。同时,该功能与当前的模块定位都不太符合,因此还新建了一个oa模块。

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

  • 目前只提供了创建、查询的接口,并没有修改与删除(我认为这部分不必要),如后续有需求应当补充。
  • 将工单编号的生成放到了后端生成。
  • 数据表中仅包含学生信息、设备信息等基本内容,这些信息应该是只读的;但是后续可能还需要加入一些信息,例如工单处理人、处理时间、处理结果是否满意等。如新增这些信息,数据修改的接口也是必须的,应当后续补充。
  • 新增代码中单元测试覆盖率较低,后续应该会再次补充。

关联需求文档:https://west2-online.feishu.cn/wiki/DvI5w9t2iiOyggktHnBc3HcbnYb

@wastefi
wastefi requested review from a team, jiuxia211, mutezebra and ozline as code owners October 6, 2025 13:34
@codecov

codecov Bot commented Oct 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 7.90754% with 1514 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
kitex_gen/oa/k-oa.go 0.00% 1091 Missing ⚠️
kitex_gen/oa/oa.go 0.00% 228 Missing ⚠️
pkg/db/oa/get_feedback.go 35.21% 31 Missing and 15 partials ⚠️
internal/oa/service/feedback_service.go 50.00% 31 Missing and 11 partials ⚠️
kitex_gen/oa/oaservice/oaservice.go 0.00% 33 Missing ⚠️
api/rpc/oa.go 0.00% 18 Missing ⚠️
internal/oa/handler.go 0.00% 18 Missing ⚠️
pkg/utils/ptr.go 0.00% 16 Missing ⚠️
api/router/api/middleware.go 0.00% 12 Missing ⚠️
api/router/api/api.go 0.00% 5 Missing ⚠️
... and 1 more
@@           Coverage Diff            @@
##            main    #340      +/-   ##
========================================
+ Coverage   5.24%   5.64%   +0.39%     
========================================
  Files        255     270      +15     
  Lines      31091   34397    +3306     
========================================
+ Hits        1630    1940     +310     
- Misses     29362   32325    +2963     
- Partials      99     132      +33     
Flag Coverage Δ
unittest 5.64% <7.90%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/handler/api/feedback_service.go 100.00% <100.00%> (ø)
internal/oa/service/service.go 100.00% <100.00%> (ø)
api/router/api/api.go 0.00% <0.00%> (ø)
kitex_gen/oa/oaservice/client.go 0.00% <0.00%> (ø)
api/router/api/middleware.go 0.00% <0.00%> (ø)
pkg/utils/ptr.go 0.00% <0.00%> (ø)
api/rpc/oa.go 0.00% <0.00%> (ø)
internal/oa/handler.go 0.00% <0.00%> (ø)
kitex_gen/oa/oaservice/oaservice.go 27.88% <0.00%> (ø)
internal/oa/service/feedback_service.go 66.43% <50.00%> (ø)
... and 3 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FantasyRL FantasyRL left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread make.err Outdated
@wastefi
wastefi requested a review from FantasyRL October 7, 2025 07:18
@ozline

ozline commented Oct 8, 2025

Copy link
Copy Markdown
Member

@FantasyRL 老大我日你大坝,微信聊天都给删干净了吗怎么来了个 approve,速速再看 2 遍

@ozline
ozline merged commit 217b7ef into west2-online:main Oct 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants