Skip to content

fix(academic): correct score notice push tag - #497

Merged
renbaoshuo merged 2 commits into
mainfrom
fix/score-push
Jul 17, 2026
Merged

fix(academic): correct score notice push tag#497
renbaoshuo merged 2 commits into
mainfrom
fix/score-push

Conversation

@ACaiCat

@ACaiCat ACaiCat commented Jul 16, 2026

Copy link
Copy Markdown
Member

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

fix

这个 PR 做了什么 / 我们为什么需要这个 PR?

服务端成绩推送tag的md5计算补加教室字段,和客户端保持一致

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

https://github.com/west2-online/fzuhelper-app/blob/83d6ae55af038ca9d26990eebda196b6d6b1733c/lib/notification.ts#L154

@ACaiCat
ACaiCat requested a review from jiuxia211 as a code owner July 16, 2026 03:53
renbaoshuo
renbaoshuo previously approved these changes Jul 16, 2026
@ACaiCat

ACaiCat commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

viper/remote → sagikazarmark/crypt → x/crypto/openpgp(弃用,GO-2026-5932),导致漏洞扫描过不了。因为我们没用到 AddSecureRemoteProvider,可以直接忽略这个漏洞,或者自己 fork 一份 sagikazarmark/crypt 解决,或者等上游更新

@cai ➜ fzuhelper-server git(fix/score-push) ✗ go mod why golang.org/x/crypto/openpgp
# golang.org/x/crypto/openpgp
github.com/west2-online/fzuhelper-server/config
github.com/spf13/viper/remote
github.com/sagikazarmark/crypt/config
github.com/sagikazarmark/crypt/encoding/secconf
golang.org/x/crypto/openpgp

@renbaoshuo
renbaoshuo merged commit 3a81b05 into main Jul 17, 2026
15 of 17 checks passed
@renbaoshuo
renbaoshuo deleted the fix/score-push branch July 17, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants