feat: exam notice - #503
Merged
Merged
Conversation
CutebreadCat
requested review from
a team,
jiuxia211,
mutezebra,
ozline and
renbaoshuo
as code owners
July 22, 2026 11:18
Penty-d
reviewed
Jul 27, 2026
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 64.29% 64.98% +0.69%
==========================================
Files 233 236 +3
Lines 6108 6312 +204
==========================================
+ Hits 3927 4102 +175
- Misses 2055 2071 +16
- Partials 126 139 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
CutebreadCat
force-pushed
the
course-notice
branch
from
July 27, 2026 15:04
6280e83 to
b1ee6f7
Compare
Penty-d
requested changes
Jul 29, 2026
| // 去重记录已经抢占成功，但通知和快照更新放入同一个异步任务。 | ||
| // 只有两步都成功，exam_offerings 记录才会继续保留。 | ||
| if !umeng.EnqueueAsync(func() error { | ||
| if err := s.sendExamNotifications(claimed); err != nil { |
Contributor
There was a problem hiding this comment.
这里enqueue是不是有点问题？一个send里可以包含n个changes，也就是发送2n个umeng请求，但这里dispatcher是按单个做限流的
Contributor
Author
There was a problem hiding this comment.
已修改为一个个change推送,并且安卓和ios推送失败不再重试
| title := fmt.Sprintf("%v考试信息更新啦", change.Exam.Name) | ||
| description := fmt.Sprintf("考试信息更新%v", change.Tag[:12]) | ||
| if err := umeng.SendAndroidGroupcastWithGoApp( | ||
| title, "", "", change.Tag, description, constants.UmengGradeDeeplink, |
Contributor
Author
There was a problem hiding this comment.
已经修正了,新增考场的deeplink
Penty-d
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自查 PR 结构
PR 标题符合这个格式: <type>(optional scope): <description>
此 PR 标题的描述以用户为导向，足够清晰，其他人可以理解。
我已经对所有 commit 提供了签名（GPG 密钥签名、SSH 密钥签名）
这个 PR 属于强制变更/破坏性更改
这个 PR 的类型是什么？
feat
这个 PR 做了什么 / 我们为什么需要这个 PR？
增加了考试通知的功能
(可选)这个 PR 解决了哪个/些 issue？
对 Reviewer 预留的一些提醒