Skip to content

refactor(common): toolbox config api - #509

Merged
renbaoshuo merged 7 commits into
mainfrom
refactor/toolbox-config-api
Aug 3, 2026
Merged

refactor(common): toolbox config api#509
renbaoshuo merged 7 commits into
mainfrom
refactor/toolbox-config-api

Conversation

@renbaoshuo

Copy link
Copy Markdown
Member

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

refactor

这个 PR 做了什么 / 我们为什么需要这个 PR?

重构工具箱管理接口。

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

@renbaoshuo
renbaoshuo requested review from a team, jiuxia211, mutezebra and ozline as code owners July 31, 2026 03:35
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.55319% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/common/service/manage_toolbox_config.go 70.37% 8 Missing and 8 partials ⚠️
api/handler/api/common_service.go 87.23% 7 Missing and 5 partials ⚠️
pkg/db/toolbox/get_configs.go 71.42% 5 Missing and 1 partial ⚠️
pkg/db/toolbox/update_config.go 82.60% 2 Missing and 2 partials ⚠️
pkg/db/toolbox/delete_config.go 81.81% 1 Missing and 1 partial ⚠️
pkg/db/toolbox/create_config.go 83.33% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   63.51%   64.07%   +0.56%     
==========================================
  Files         234      239       +5     
  Lines        6169     6450     +281     
==========================================
+ Hits         3918     4133     +215     
- Misses       2127     2162      +35     
- Partials      124      155      +31     
Flag Coverage Δ
unittest 64.07% <82.55%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/common/service/get_toolbox_config.go 100.00% <100.00%> (ø)
internal/common/service/list_toolbox_configs.go 80.95% <100.00%> (ø)
pkg/db/toolbox/create_config.go 71.42% <83.33%> (ø)
pkg/db/toolbox/delete_config.go 81.81% <81.81%> (ø)
pkg/db/toolbox/update_config.go 82.60% <82.60%> (ø)
pkg/db/toolbox/get_configs.go 71.42% <71.42%> (+1.86%) ⬆️
api/handler/api/common_service.go 91.86% <87.23%> (-8.14%) ⬇️
internal/common/service/manage_toolbox_config.go 70.37% <70.37%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread api/handler/api/common_service_test.go Outdated
@renbaoshuo
renbaoshuo requested a review from ACaiCat August 2, 2026 07:43
Comment thread pkg/db/toolbox/manage_configs_test.go
Comment thread pkg/db/toolbox/create_config.go
@renbaoshuo

renbaoshuo commented Aug 2, 2026 via email

Copy link
Copy Markdown
Member Author

@renbaoshuo
renbaoshuo merged commit 24514d3 into main Aug 3, 2026
10 checks passed
@renbaoshuo
renbaoshuo deleted the refactor/toolbox-config-api branch August 3, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants