Skip to content

fix(singleflight): use extracted student ID for stable keys across sessions #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renbaoshuo merged 1 commit into from
Aug 5, 2026
Merged

fix(singleflight): use extracted student ID for stable keys across sessions #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/academic/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ func (s *AcademicServiceImpl) GetScores(ctx context.Context, _ *academic.GetScor
if err != nil {
return nil, fmt.Errorf("Academic.GetScores: Get login data fail %w", err)
}
stuId := loginData.Id
isGraduate := utils.IsGraduate(stuId)
stuId := metainfoContext.ExtractIDFromLoginData(loginData)
isGraduate := utils.IsGraduate(loginData.Id)
key := singleflight.Key(constants.SingleflightScoresPrefix, stuId, isGraduate)
if isGraduate {
scores, err := singleflight.Do(key, func() ([]*yjsy.Mark, error) {
Expand Down
4 changes: 2 additions & 2 deletions internal/classroom/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ func (s *ClassroomServiceImpl) GetExamRoomInfo(ctx context.Context, req *classro
if err != nil {
return nil, fmt.Errorf("Classroom.GetExamRoomInfo: Get login data fail %w", err)
}
stuId := loginData.Id
isGraduate := utils.IsGraduate(stuId)
stuId := metainfoContext.ExtractIDFromLoginData(loginData)
isGraduate := utils.IsGraduate(loginData.Id)
key := singleflight.Key(constants.SingleflightExamRoomsPrefix, stuId, req.GetTerm(), isGraduate)

rooms, err := singleflight.Do(key, func() ([]*model.ExamRoomInfo, error) {
Expand Down
8 changes: 4 additions & 4 deletions internal/course/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ func (s *CourseServiceImpl) GetCourseList(ctx context.Context, req *course.Cours
if err != nil {
return nil, fmt.Errorf("Course.GetCourseList: Get login data fail %w", err)
}
stuId := loginData.Id
isGraduate := utils.IsGraduate(stuId)
stuId := metainfoContext.ExtractIDFromLoginData(loginData)
isGraduate := utils.IsGraduate(loginData.Id)
isRefresh := req.IsRefresh != nil && *req.IsRefresh
key := singleflight.Key(constants.SingleflightCourseListPrefix, stuId, req.Term, isGraduate, isRefresh)

Expand Down Expand Up @@ -82,8 +82,8 @@ func (s *CourseServiceImpl) GetTermList(ctx context.Context, req *course.TermLis
if err != nil {
return nil, fmt.Errorf("Course.GetTermList: Get login data fail %w", err)
}
stuId := loginData.Id
isGraduate := utils.IsGraduate(stuId)
stuId := metainfoContext.ExtractIDFromLoginData(loginData)
isGraduate := utils.IsGraduate(loginData.Id)
key := singleflight.Key(constants.SingleflightCourseTermsPrefix, stuId, isGraduate)

res, err := singleflight.Do(key, func() ([]string, error) {
Expand Down
4 changes: 2 additions & 2 deletions internal/user/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ func (s *UserServiceImpl) GetUserInfo(ctx context.Context, request *user.GetUser
resp.Base = base.BuildBaseResp(err)
return resp, nil
}
stuId := loginData.Id
isGraduate := utils.IsGraduate(stuId)
stuId := metainfoContext.ExtractIDFromLoginData(loginData)
isGraduate := utils.IsGraduate(loginData.Id)
key := singleflight.Key(constants.SingleflightUserInfoPrefix, stuId, isGraduate)

info, err := singleflight.Do(key, func() (*db.Student, error) {
Expand Down