fs: rebuild zone lifetime while mount #283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravind-wdc
reviewed
Oct 30, 2023
Contributor
There was a problem hiding this comment.
Can you please add a little more context to the commit message to reflect the need for this change or use case where this would be beneficial ?
And have you tested the impact of this change during mount on an almost full filesystem(ZenFS) on a large drive? Since we are going through all extents of all files in foreground I think it would add significant delay during mount, when the filesystem is full or almost full.
And also you need to rebase with base branch.
Signed-off-by: Yu Wang <[email protected]>
ywang-wnlo
force-pushed
the
zone_lifetime
branch
from
4ce58d9 to
fce7037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#266