fs: fix compile error on latest RocksDB#300
Merged
Merged
Conversation
WritableFile::GetFileSize needs to be imlemented now, so hook it up to make it compilable on latest rocksdb. Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
yhr
force-pushed
the
fssize_compile_fix
branch
from
3e44af2 to
cfafae3
Compare
Contributor
MaisenbacherD
approved these changes
Jan 22, 2025
Collaborator
Author
|
Looks like tests complete just fine but CI data collection is missbehaving, pulling this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WritableFile::GetFileSize needs to be imlemented now, so hook it up to make it compilable on latest rocksdb.