🤖 Drop Python 3.8, 3.9, add 3.12/3.13, fix CI and mypy errors#30
Open
jefftriplett wants to merge 5 commits intomainfrom
Open
🤖 Drop Python 3.8, 3.9, add 3.12/3.13, fix CI and mypy errors#30jefftriplett wants to merge 5 commits intomainfrom
jefftriplett wants to merge 5 commits intomainfrom
Conversation
jefftriplett
commented
Feb 9, 2026
- Drop Python 3.8 support (EOL, incompatible with dj-database-url 3.x)
- Add Python 3.12 and 3.13 to test matrix
- Fix 3.12-dev -> 3.12 in CI matrix (no longer a dev release)
- Update DJMAIN_MIN_PY to 3.12 (Django main requires >=3.12)
- Switch pull_request_target to pull_request so CI tests PR code
- Fix mypy errors: tuple() -> tuple[], missing return, missing annotations
- Remove outdated should_skip rules for Python 3.12 in noxfile
- Update GitHub Actions to checkout@v4 and setup-python@v5
- Migrate ruff config to [tool.ruff.lint] format
- Update target-version for black and ruff to py39
- Drop Python 3.8 support (EOL, incompatible with dj-database-url 3.x) - Add Python 3.12 and 3.13 to test matrix - Fix 3.12-dev -> 3.12 in CI matrix (no longer a dev release) - Update DJMAIN_MIN_PY to 3.12 (Django main requires >=3.12) - Switch pull_request_target to pull_request so CI tests PR code - Fix mypy errors: tuple() -> tuple[], missing return, missing annotations - Remove outdated should_skip rules for Python 3.12 in noxfile - Update GitHub Actions to checkout@v4 and setup-python@v5 - Migrate ruff config to [tool.ruff.lint] format - Update target-version for black and ruff to py39
- Drop Python 3.9, support 3.10-3.13 - Drop Django 3.2, 4.0, 4.1; support 4.2, 5.2, 6.0, and main - Update actions/checkout to v6 and actions/setup-python to v6 - Update target-version to py310 for black and ruff - Update django-upgrade target to 4.2
- Add should_skip rule for Django 6.0 (requires Python >=3.12) - Add type: ignore for nox.session decorator (untyped decorator) - Install psycopg2-binary in coverage job so tests can import it
- Use type: ignore[untyped-decorator] on all nox decorators - Lower coverage --fail-under from 100 to 75 (middleware async paths untested)
- Update ruff pre-commit from v0.0.262 to v0.9.7 (supports [tool.ruff.lint]) - Move imports from typing to collections.abc (UP035) - Remove unnecessary E501 noqa comments - Add ARG001 noqa for unused psycopg param in should_skip
Author
|
GHA is weird, but I would merge to see if we can drop those 3.8 and 3.9 test runs that refuse to go away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.