Draft
Conversation
This cli command imports a bank-statement into a yaml file, where annotations can be made, i.e. bookings can be accounted to customers. Currently only Postbank is supported.
* flake now really exits non-zero if errors are found * black exists non-zero if errors are found * install requirements-dev.txt instead of user requirements
also the flake8 check as it is run on the ci is added to this command
olf42
changed the title
*TODO: save reports *TODO: batch report *TODO: pdf reports *TODO: send reports
aparcar
requested changes
Oct 21, 2019
I suspect this, or the fact that the datadir is a symlink prevents the ci checks from passing
aparcar
reviewed
Oct 22, 2019
Collaborator
aparcar
left a comment
aparcar
left a comment
There was a problem hiding this comment.
Why adding another CI system?
aparcar
reviewed
Oct 22, 2019
Collaborator
|
Overall mixing package updates, CI updates and new CSV features in a single request makes it a bit hart to review :) |
Member
Author
|
Sorry :(
Yeah. I fucked this one up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My Draft for payment processing.
Unfortunately I was not attentive enough, to pack the ci improvements into a separate branch. :/