GC Combo-box component (WET-631)#2719
Open
BrahimMahadi wants to merge 1 commit intowet-boew:masterfrom
Open
Conversation
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-combobox
branch
from
b8c87c8 to
0bbc112
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-combobox
branch
from
0bbc112 to
55e62e1
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-combobox
branch
from
55e62e1 to
678329e
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-combobox
branch
from
678329e to
9760a0b
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-combobox
branch
from
9760a0b to
64f5d42
Compare
BrahimMahadi
force-pushed
the
gc-combobox
branch
from
64f5d42 to
e564f03
Compare
Garneauma
requested changes
Apr 7, 2026
Collaborator
Garneauma
left a comment
Garneauma
left a comment
There was a problem hiding this comment.
This is just a quick partial review.
| } | ||
|
|
||
| // Register the custom element | ||
| customElements.define( "combo-box-component", ComboBoxComponent ); |
Collaborator
There was a problem hiding this comment.
Let's go with "gc-combobox" for now.
| } | ||
|
|
||
| // Returns the encapsulated styles for the Shadow DOM | ||
| getStyles() { |
Collaborator
There was a problem hiding this comment.
Can you find a way to get styles from a CSS file instead? This would be easier to test using our linting tools.
Comment on lines
+62
to
+63
| const label = this.getAttribute( "label" ) || "Select items"; | ||
| const placeholder = this.getAttribute( "placeholder" ) || "Type to search or add items..."; |
Collaborator
There was a problem hiding this comment.
Those default values would need to use i18n strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An accessible combo-box component that provides a modern, user-friendly interface for selecting multiple items. Reference JIRA ticket WET-631.