Add config for INSPIRE v5.0 schemas to portrayal repository #42
Conversation
As part of a proof-of-concept to support both INSPIRE 4.0 and 5.0 in parallel on hale connect, the repository was extended with styling for the Protected Sites schema in version 5.0 by adding the file PS_ProtectedSites_v5.se, importing the ps 5.0 namespace, and creating the corresponding style and layer configurations, leaving the existing 4.0 setup fully intact. SVC-2136
Add the eclipse settings regarding the version and encoding. This is done because otherwise "Umlaute" are not displayed correctly. SVC-2136
Test color changes in the INSPIRE PS 5.0 SE style to verify that the correct SE file is selected when using the corresponding schema. SVC-2136
Take back colour change in INSPIRE PS 5.0 style to original/correct colour as the test to verify that the correct SE file is selected when using the corresponding schema was successful. SVC-2136
Take back colour change in INSPIRE PS 5.0 style to original/correct colour as the test to verify that the correct SE file is selected when using the corresponding schema was successful. SVC-2136
Copy the se files that are affected by changes to the INSPIRE v5.0 schema. These have the same content in this commit as the INSPIRE v4.0 se files, so that changes can be tracked more easily in future commits. SVC-2136
the namespaces of the se files whose corresponding inspire schemas are available in version 5.0 are adapted. SVC-2136
Add the appropriate configuration for the INSPIRE 5.0 se files to the config.styles and confg.xmi files. SVC-2177
This commit adds the automatically generated config.xml as well as the files config.xml, config.xmi, generated.style and se-files, which are located in the generated/ folder. All files are created through an automated process using Eclipse. SVC-2177
Removed a duplicate PS 5.0 configuration that was created during PS 5.0 testing. This configuration was deleted to maintain consistency with the other setups. SVC-2177
This commit adds the automatically generated config.xml, config.xmi and generated.style, located in the generated/ directory. These files were regenerated as a result of removing the duplicate PS 5.0 configuration. All files are produced automatically by Eclipse. SVC-2177
|
Unfortunately, I will not find the time to review very soon. @Ramona-wetransform Would be great if you could take that over |
|
Is a detailed challenge even necessary here? According to the description, the changes have already been checked in #39 . And this is about transferring to the public repo? Am I understanding that correctly? I'm not familiar with the structure of the Portrayl repo. |
|
@Ramona-wetransform Yes, changes have already been checked in #39 and were tested on test hc, which uses the configuration of the testing branch of this repo. This PR is just for merging the testing branch into the main to make the changes available for hc production. |
Ramona-wetransform
left a comment
Ramona-wetransform
left a comment
There was a problem hiding this comment.
Duplicate: these changes have already been made in a previous commit, which originally came from a different branch/PR.
|
Adjustments were reviewed in several previous PRs. These are now being merged:
|
@fab-fleischer @Ramona-wetransform If they were already merged, couldn't we rebase this branch to master to make sure only the expected changes are kept in the PR? |
Yes, however, this PR should reflect the current status of the testing branch; the additional commits merely provide a more detailed history of how this status was achieved. |
Due to a version change of several INSPIRE schemas from version 4.0 to version 5.0 (see https://inspire.ec.europa.eu/schemas/readme.txt) the corresponding SE files in the portrayal repository had to be updated and reconfigured. The changes were implemented as part of SVC-2177. However, these adjustments do not yet include INSPIRE schemas newly introduced after schema release v2025.1. These will be configured as part of SVC-2372 and added at a later stage.
This PR was reviewed, when merged into testing (see #39)