You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for instance when contracts appear as duplicates when ingesting from a single Foundry project that depends on others foundry projects.
In this case getArtifactPaths() in the Foundry plugin pick up the same contracts twice since they end up existing in both out/ directories. I don't think there is a reliable to heuristic to de-duplicate them at this level.
It seems like duck-typing contracts by the ABI should be fine, it could always be enabled via an option.
…ical ABIs
This is useful for instance when contracts appear as duplicates when
ingesting from a single Foundry project that depends on others foundry
projects.
In this case `getArtifactPaths()` in the Foundry plugin pick up the same
contracts twice since they end up existing in both `out/` directories. I
don't think there is a reliable to heuristic to de-duplicate them at
this level.
It seems like duck-typing contracts by the ABI should be fine, it could
always be enabled via an option.
Signed-off-by: Silas Davis <[email protected]>
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
silasdavis
changed the title
feat: Soften duplicate contract name in the case contracts have ident…
feat: Soften duplicate contract name in the case contracts have identical ABIs
Jun 2, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
silasdavis
changed the title
This is useful for instance when contracts appear as duplicates when ingesting from a single Foundry project that depends on others foundry projects.
In this case
getArtifactPaths()in the Foundry plugin pick up the same contracts twice since they end up existing in bothout/directories. I don't think there is a reliable to heuristic to de-duplicate them at this level.It seems like duck-typing contracts by the ABI should be fine, it could always be enabled via an option.