Skip to content

fix pytest-django dep skip issue on fastapi project#11

Merged
wey-gu merged 3 commits intomainfrom
fix_django_skip_issue
Jun 11, 2025
Merged

fix pytest-django dep skip issue on fastapi project#11
wey-gu merged 3 commits intomainfrom
fix_django_skip_issue

Conversation

@wey-gu
Copy link
Owner

@wey-gu wey-gu commented Jun 11, 2025

as titled...

@wey-gu wey-gu requested a review from Copilot June 11, 2025 03:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes how pytest-django tests are skipped when the plugin is missing, bumps the package version, and updates examples/docs to clarify optional pytest-django integration.

  • Use an explicit pytest-django marker for skipping tests
  • Bump version from 0.2.0 to 0.2.1
  • Clarify and enhance example usage and README instructions for optional pytest-django integration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
py_pglite/pytest_plugin.py Change marker name for pytest-django skip check
py_pglite/init.py Bump package version to 0.2.1
examples/testing-patterns/django/test_pytest_django.py Update example docstring and comments for optional integration
examples/README.md Add commands for both basic Django tests and pytest-django usage
Comments suppressed due to low confidence (1)

examples/testing-patterns/django/test_pytest_django.py:122

  • [nitpick] Mixing Chinese and English in code comments may confuse readers. Consider using a single language consistently for example comments.
# Django tests (基础用法)

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.64%. Comparing base (bf09b41) to head (83ff2de).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
py_pglite/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   20.64%   20.64%           
=======================================
  Files          15       15           
  Lines        1114     1114           
=======================================
  Hits          230      230           
  Misses        884      884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wey-gu wey-gu force-pushed the fix_django_skip_issue branch 2 times, most recently from dd7a0a2 to 6b251d0 Compare June 11, 2025 05:40
@wey-gu wey-gu force-pushed the fix_django_skip_issue branch from 2857773 to 83ff2de Compare June 11, 2025 08:37
@wey-gu wey-gu merged commit 3012893 into main Jun 11, 2025
8 checks passed
@wey-gu wey-gu deleted the fix_django_skip_issue branch June 11, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments