feat(macos): add support for titlebar background matching theme background on macos #6558
+137
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-Madden
changed the title
Jay-Madden
changed the title
Jay-Madden
commented
Jan 18, 2025
Jay-Madden
added a commit
to Jay-Madden/wezterm-fork
that referenced
this pull request
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for changing the background color of the titlebar on macos.
Adding a new macos window decoration option
MACOS_RESPECT_THEME_BACKGROUNDWith the following wezterm config
the titlebar is rendered like this
It also works for the default theme, being rendered like this
Important
The
CGColorCreateSrgb()binding was introduced in catalina meaning this functionality will fail on older operating systems. I couldnt find a "support OS" matrix but I did find this comment from wez discussing a similar issue. #1819 (comment) in big sur, which is one year newer then catalina so this break in legacy support shouldnt break anything existing as it was already unsupported.Tasks
Ref: #6557