Update Select.vue to handle undefined button case #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the X button has been pressed on the select element then the select component itself is no longer visible for whatever reason, the `$refs.btn` is `undefined`. Check for this to avoid `Uncaught TypeError: Cannot read property 'focus' of undefined`. Note: The use case in this instance for me is having the select component in a tab, when the X is pressed, I change tab thus removing the select component from scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the X button has been pressed on the select element then the select component itself is no longer visible for whatever reason, the
$refs.btnisundefined. Check for this to avoidUncaught TypeError: Cannot read property 'focus' of undefined.Note: The use case in this instance for me is having the select component in a tab, when the X is pressed, I change tab thus removing the select component from scope.