Fix middleware#107
Merged
Merged
Conversation
jgrund
commented
Aug 26, 2025
jgrund
commented
Contributor
- Fix load shed to be global
- Add response timeout
- Add compression support
jgrund
commented
Aug 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 43 43
Lines 5389 5391 +2
Branches 5389 5391 +2
=======================================
+ Hits 4999 5001 +2
Misses 326 326
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bencher Report
|
| Branch | jgrund/add-middleware |
| Testbed | ci-runner |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- peak_over_start_rss_ratio (Measure (units))
- virtual_growth_mib (Measure (MiB))
- avg_runtime_virtual_mib (Measure (MiB))
- end_rss_mib (Measure (MiB))
- start_rss_mib (Measure (MiB))
- avg_runtime_rss_mib (Measure (MiB))
- memory_growth_mib (Measure (MiB))
- start_virtual_mib (Measure (MiB))
- peak_over_start_virtual_ratio (Measure (units))
- end_virtual_mib (Measure (MiB))
- peak_virtual_mib (Measure (MiB))
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | avg_runtime_rss_mib | Measure (MiB) | avg_runtime_virtual_mib | Measure (MiB) x 1e3 | end_rss_mib | Measure (MiB) | end_virtual_mib | Measure (MiB) x 1e3 | memory_growth_mib | Measure (MiB) | peak_over_start_rss_ratio | Measure (units) | peak_over_start_virtual_ratio | Measure (units) | peak_rss_mib | Benchmark Result Measure (MiB) (Result Δ%) | Lower Boundary Measure (MiB) (Limit %) | Upper Boundary Measure (MiB) (Limit %) | peak_virtual_mib | Measure (MiB) x 1e3 | start_rss_mib | Measure (MiB) | start_virtual_mib | Measure (MiB) x 1e3 | virtual_growth_mib | Measure (MiB) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| scrape_allocations | 📈 view plot | 92.52 MiB | 📈 view plot | 1.38 MiB x 1e3 | 📈 view plot | 93.17 MiB | 📈 view plot | 1.38 MiB x 1e3 | 📈 view plot | 5.57 MiB | 📈 view plot | 1.94 units | 📈 view plot | 1.23 units | 📈 view plot 🚷 view threshold | 95.29 MiB(+0.19%)Baseline: 95.11 MiB | 94.58 MiB (99.25%) | 95.64 MiB (99.64%) | 📈 view plot | 1.40 MiB x 1e3 | 📈 view plot | 87.59 MiB | 📈 view plot | 1.31 MiB x 1e3 | 📈 view plot | 70.14 MiB |
added 2 commits
August 26, 2025 14:34
- Fix load shed to be global - Add response timeout - Add compression support Signed-off-by: Joe Grund <jgrund@whamcloud.io>
jgrund
force-pushed
the
jgrund/add-middleware
branch
from
c8ee605 to
601c39c
Compare
|
| Branch | jgrund/add-middleware |
| Testbed | ci-runner |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Lower Boundary milliseconds (ms) (Limit %) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|---|
| jobstats otel 100 | 📈 view plot 🚷 view threshold | 1.68 ms(+1.60%)Baseline: 1.65 ms | 1.61 ms (96.28%) | 1.69 ms (99.43%) |
| jobstats otel 1000 | 📈 view plot 🚷 view threshold | 15.41 ms(+0.55%)Baseline: 15.32 ms | 15.20 ms (98.66%) | 15.45 ms (99.76%) |
|
| Branch | jgrund/add-middleware |
| Testbed | ci-runner |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- Total read+write (reads/writes)
- D1mr (misses (reads))
- L1 Hit Rate (hits (%))
- LL Hits (hits)
- LL Miss Rate (misses (%))
- D1 Miss Rate (misses (%))
- RAM Hit Rate (hits (%))
- I1 Miss Rate (misses (%))
- D1mw (misses (writes))
- RAM Hits (hits)
- L1 Hits (hits)
- DLmr (misses (reads))
- Dw (writes)
- Estimated Cycles (cycles)
- ILmr (misses (reads))
- Dr (reads)
- LLi Miss Rate (misses (%))
- LL Hit Rate (hits (%))
- DLmw (misses (writes))
- I1mr (misses (reads))
- LLd Miss Rate (misses (%))
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | D1 Miss Rate | misses (%) | D1mr | misses (reads) x 1e3 | D1mw | misses (writes) x 1e3 | DLmr | misses (reads) | DLmw | misses (writes) x 1e3 | Dr | reads x 1e6 | Dw | writes x 1e6 | Estimated Cycles | cycles x 1e6 | I1 Miss Rate | misses (%) | I1mr | misses (reads) x 1e3 | ILmr | misses (reads) x 1e3 | Instructions | Benchmark Result instructions x 1e6 (Result Δ%) | Lower Boundary instructions x 1e6 (Limit %) | Upper Boundary instructions x 1e6 (Limit %) | L1 Hit Rate | hits (%) | L1 Hits | hits x 1e6 | LL Hit Rate | hits (%) | LL Hits | hits x 1e3 | LL Miss Rate | misses (%) | LLd Miss Rate | misses (%) | LLi Miss Rate | misses (%) | RAM Hit Rate | hits (%) | RAM Hits | hits x 1e3 | Total read+write | reads/writes x 1e6 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| lustre_metrics::memory_benches::bench_encode_lustre_metrics with_setup:generate_records() | 📈 view plot | 1.50 % | 📈 view plot | 117.98 reads x 1e3 | 📈 view plot | 42.80 writes x 1e3 | 📈 view plot | 133.00 reads | 📈 view plot | 31.06 writes x 1e3 | 📈 view plot | 6.18 x 1e6 | 📈 view plot | 4.53 x 1e6 | 📈 view plot | 40.15 x 1e6 | 📈 view plot | 0.02 % | 📈 view plot | 4.63 reads x 1e3 | 📈 view plot | 2.46 reads x 1e3 | 📈 view plot 🚷 view threshold | 27.77 x 1e6(-0.09%)Baseline: 27.80 x 1e6 | 27.75 x 1e6 (99.92%) | 27.84 x 1e6 (99.74%) | 📈 view plot | 99.57 % | 📈 view plot | 38.31 x 1e6 | 📈 view plot | 0.34 % | 📈 view plot | 131.76 x 1e3 | 📈 view plot | 0.09 % | 📈 view plot | 0.29 % | 📈 view plot | 0.01 % | 📈 view plot | 0.09 % | 📈 view plot | 33.66 x 1e3 | 📈 view plot | 38.48 x 1e6 |
|
| Branch | jgrund/add-middleware |
| Testbed | ci-runner |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- end_rss_mib (Measure (MiB))
- end_virtual_mib (Measure (MiB))
- start_rss_mib (Measure (MiB))
- virtual_growth_mib (Measure (MiB))
- peak_over_start_virtual_ratio (Measure (units))
- memory_growth_mib (Measure (MiB))
- start_virtual_mib (Measure (MiB))
- avg_runtime_rss_mib (Measure (MiB))
- peak_virtual_mib (Measure (MiB))
- peak_over_start_rss_ratio (Measure (units))
- avg_runtime_virtual_mib (Measure (MiB))
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | avg_runtime_rss_mib | Measure (MiB) | avg_runtime_virtual_mib | Measure (MiB) x 1e3 | end_rss_mib | Measure (MiB) | end_virtual_mib | Measure (MiB) x 1e3 | memory_growth_mib | Measure (MiB) | peak_over_start_rss_ratio | Measure (units) | peak_over_start_virtual_ratio | Measure (units) | peak_rss_mib | Benchmark Result Measure (MiB) (Result Δ%) | Lower Boundary Measure (MiB) (Limit %) | Upper Boundary Measure (MiB) (Limit %) | peak_virtual_mib | Measure (MiB) x 1e3 | start_rss_mib | Measure (MiB) | start_virtual_mib | Measure (MiB) x 1e3 | virtual_growth_mib | Measure (MiB) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| scrape_allocations | 📈 view plot | 92.89 MiB | 📈 view plot | 1.29 MiB x 1e3 | 📈 view plot | 93.55 MiB | 📈 view plot | 1.29 MiB x 1e3 | 📈 view plot | 5.77 MiB | 📈 view plot | 1.88 units | 📈 view plot | 1.22 units | 📈 view plot 🚷 view threshold | 98.73 MiB(+3.29%)Baseline: 95.58 MiB | 92.07 MiB (93.25%) | 99.10 MiB (99.62%) | 📈 view plot | 1.40 MiB x 1e3 | 📈 view plot | 87.78 MiB | 📈 view plot | 1.22 MiB x 1e3 | 📈 view plot | 70.15 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.