Switch serde_yaml to yaml_serde#138
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 45 45
Lines 5958 5958
Branches 5958 5958
=======================================
Hits 5640 5640
Misses 245 245
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bencher Report| Branch | nclark/yaml |
| Testbed | ci-runner |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| parse_benchmarks/combine_performance | 📈 view plot 🚷 view threshold | 115,980,000.00 ns(-57.41%)Baseline: 272,288,125.00 ns | -775,761,310.11 ns (-668.88%) | 1,320,337,560.11 ns (8.78%) |
|
| Branch | nclark/yaml |
| Testbed | ci-runner |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- RAM Hit Rate (hits (%))
- LL Miss Rate (misses (%))
- I1 Miss Rate (misses (%))
- LL Hit Rate (hits (%))
- LLi Miss Rate (misses (%))
- Dw (writes)
- D1mr (misses (reads))
- Estimated Cycles (cycles)
- RAM Hits (hits)
- DLmr (misses (reads))
- ILmr (misses (reads))
- L1 Hits (hits)
- D1 Miss Rate (misses (%))
- L1 Hit Rate (hits (%))
- D1mw (misses (writes))
- LL Hits (hits)
- Total read+write (reads/writes)
- DLmw (misses (writes))
- Dr (reads)
- LLd Miss Rate (misses (%))
- I1mr (misses (reads))
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | D1 Miss Rate | misses (%) | D1mr | misses (reads) x 1e3 | D1mw | misses (writes) x 1e3 | DLmr | misses (reads) | DLmw | misses (writes) x 1e3 | Dr | reads x 1e6 | Dw | writes x 1e6 | Estimated Cycles | cycles x 1e6 | I1 Miss Rate | misses (%) | I1mr | misses (reads) x 1e3 | ILmr | misses (reads) | Instructions | Benchmark Result instructions x 1e6 (Result Δ%) | Lower Boundary instructions x 1e6 (Limit %) | Upper Boundary instructions x 1e6 (Limit %) | L1 Hit Rate | hits (%) | L1 Hits | hits x 1e6 | LL Hit Rate | hits (%) | LL Hits | hits x 1e3 | LL Miss Rate | misses (%) | LLd Miss Rate | misses (%) | LLi Miss Rate | misses (%) | RAM Hit Rate | hits (%) | RAM Hits | hits x 1e3 | Total read+write | reads/writes x 1e6 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| lustre_metrics::memory_benches::bench_encode_lustre_metrics with_setup:generate_records() | 📈 view plot | 0.92 % | 📈 view plot | 24.76 reads x 1e3 | 📈 view plot | 9.17 writes x 1e3 | 📈 view plot | 117.00 reads | 📈 view plot | 6.49 writes x 1e3 | 📈 view plot | 2.46 x 1e6 | 📈 view plot | 1.22 x 1e6 | 📈 view plot | 14.75 x 1e6 | 📈 view plot | 0.01 % | 📈 view plot | 1.05 reads x 1e3 | 📈 view plot | 874.00 reads | 📈 view plot 🚷 view threshold | 10.70 x 1e6(-21.87%)Baseline: 13.70 x 1e6 | 2.09 x 1e6 (19.58%) | 25.30 x 1e6 (42.30%) | 📈 view plot | 99.76 % | 📈 view plot | 14.35 x 1e6 | 📈 view plot | 0.19 % | 📈 view plot | 27.50 x 1e3 | 📈 view plot | 0.05 % | 📈 view plot | 0.18 % | 📈 view plot | 0.01 % | 📈 view plot | 0.05 % | 📈 view plot | 7.48 x 1e3 | 📈 view plot | 14.38 x 1e6 |
ip1981
approved these changes
May 19, 2026
serde_yaml has been depricated as unsupported. yaml_serde seems to be the successor package. Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde_yaml has been depricated as unsupported.
yaml_serde seems to be the successor package.