yoshino-common: add AVB configs for build signing #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to follow the LineageOS Signing Builds instructions,
sign_target_files_apks fails with a backtrace and the message:
KeyError: 'avb_avbtool'
The tool is expecting misc_info.txt to contain an 'avb_avbtool' entry,
which is written by build/make/core/Makefile only if BOARD_AVB_ENABLE
is true. This patch sets that variable, along with a few more that the
Makefile requires with it, as recommended here:
https://gitlab.com/LineageOS/issues/android/-/issues/3388
https://review.lineageos.org/c/LineageOS/android_device_xiaomi_sdm845-common/+/308710
fixes whatawurst#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to follow the LineageOS Signing Builds instructions, sign_target_files_apks fails with a backtrace and the message:
The tool is expecting misc_info.txt to contain an 'avb_avbtool' entry, which is written by build/make/core/Makefile only if BOARD_AVB_ENABLE is true. This patch sets that variable, along with a few more that the Makefile requires with it, as recommended here:
https://gitlab.com/LineageOS/issues/android/-/issues/3388
https://review.lineageos.org/c/LineageOS/android_device_xiaomi_sdm845-common/+/308710
fixes #121