Address infinite loop in TreeWalker's nextNode()#1433
Merged
Conversation
annevk
added
needs tests
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
annevk
force-pushed
the
annevk/infinite-loop
branch
from
May 21, 2026 11:24
68749ea to
ea93637
Compare
smaug----
approved these changes
May 21, 2026
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 27, 2026
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 29, 2026
…, a=testonly Automatic update from web-platform-tests DOM: more TreeWalker nextNode() coverage Complements whatwg/dom#1433. -- wpt-commits: d2cf5e8afc8df9f64481ce9709ff7c1afb34ed7c wpt-pr: 60053
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 1, 2026
…, a=testonly Automatic update from web-platform-tests DOM: more TreeWalker nextNode() coverage Complements whatwg/dom#1433. -- wpt-commits: d2cf5e8afc8df9f64481ce9709ff7c1afb34ed7c wpt-pr: 60053 UltraBlame original commit: 8538c7d778118f531b4f39817e43fb9b7ab204be
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 1, 2026
…, a=testonly Automatic update from web-platform-tests DOM: more TreeWalker nextNode() coverage Complements whatwg/dom#1433. -- wpt-commits: d2cf5e8afc8df9f64481ce9709ff7c1afb34ed7c wpt-pr: 60053 UltraBlame original commit: 8538c7d778118f531b4f39817e43fb9b7ab204be
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 1, 2026
…, a=testonly Automatic update from web-platform-tests DOM: more TreeWalker nextNode() coverage Complements whatwg/dom#1433. -- wpt-commits: d2cf5e8afc8df9f64481ce9709ff7c1afb34ed7c wpt-pr: 60053 UltraBlame original commit: 8538c7d778118f531b4f39817e43fb9b7ab204be
|
Sorry for the wait! I've just implemented this instead of the hack that Ladybird had previously, and I'm not seeing any regressions so I think this is correct. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests: web-platform-tests/wpt#60053.
Fixes #1102.
@Lubrsi @awesomekling @smaug---- care to review? (Specification is based on Gecko's implementation, but clearly missed the mark here.)
Preview | Diff