Restore deep cloning of shadow root contents.#1480
Merged
Conversation
This restores the behaviour introduced by whatwg#1272. After whatwg#1334, the shadow-root cloning step says to clone each child of the shadow root with `subtree` set to `subtree`. When the original call is `host.cloneNode(false)`, that causes each direct child of a clonable shadow root to be cloned shallowly. That contradicts the behaviour agreed in whatwg#1249 / whatwg#1272 and the WPT `shadow-dom/shadow-root-clonable.html`, which expects a clonable shadow root to be cloned in its entirety even when the shadow host is shallow-cloned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the behaviour introduced by #1272.
After #1334, the shadow-root cloning step says to clone each child of the shadow root with
subtreeset tosubtree. When the original call ishost.cloneNode(false), that causes each direct child of a clonable shadow root to be cloned shallowly.That contradicts the behaviour agreed in #1249 / #1272 and the WPT
shadow-dom/shadow-root-clonable.html, which expects a clonable shadow root to be cloned in its entirety even when the shadow host is shallow-cloned.Preview | Diff