Editorial: improve ensure pre-insert validity#1484
Merged
Conversation
This improves on two fronts: 1. Removing ambiguity by having individual conditions more clearly separated. 2. Reducing duplication by making the algorithm suitable for the replace operation as well.
noamr
approved these changes
Jul 8, 2026
|
|
||
| <li><p>If <var>node</var> is a {{CharacterData}} <a for=/>node</a>, then return. | ||
|
|
||
| <li><p>Let <var>exclude</var> be <var>child</var> if <var>isReplace</var> is true; otherwise null. |
Contributor
There was a problem hiding this comment.
Maybe call this childToExclude or replacedChild? it reads like a boolean otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves on two fronts:
Fixes #870.
Preview | Diff