Let replaceChildren() replace a document's children#1487
Merged
Conversation
replaceChildren() removes all of the parent's children before inserting, but "ensure pre-insert validity" still counted them. So replacing a document's children, e.g. document.replaceChildren(element), threw a "HierarchyRequestError" DOMException even though the result would be a valid document. Generalize the childToExclude concept (added for replace()) into a list of children to exclude from the validity checks, and have replaceChildren() exclude all of the parent's children. As the child being replaced is now handled uniformly, the isReplace boolean is gone. Tests: web-platform-tests/wpt#61154. Fixes #1045.
Contributor
|
Yeah, the change seems reasonable. |
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Jul 10, 2026
https://bugs.webkit.org/show_bug.cgi?id=318945 Reviewed by Ryosuke Niwa. This aligns us with an upcoming DOM standard change that makes replaceChildren() consistent with the other mutation methods: whatwg/dom#1487 Tests are updated as per: web-platform-tests/wpt#61154 Canonical link: https://commits.webkit.org/316909@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaceChildren() removes all of the parent's children before inserting, but "ensure pre-insert validity" still counted them. So replacing a document's children, e.g. document.replaceChildren(element), threw a "HierarchyRequestError" DOMException even though the result would be a valid document.
Generalize the childToExclude concept (added for replace()) into a list of children to exclude from the validity checks, and have replaceChildren() exclude all of the parent's children. As the child being replaced is now handled uniformly, the isReplace boolean is gone.
Fixes #1045.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff