Copy a document's base URL when cloning#1492
Open
annevk wants to merge 1 commit into
Open
Conversation
The baseURI getter now defers to a new "get the base URL" algorithm, which returns null by default and falls back to the node document's URL. HTML overrides this algorithm (to return the document base URL), so DOM no longer reaches into HTML for a value returned by a DOM API. Cloning a document now copies its base URL into a new "base URL override", so that a shallow clone, which has no base element, still reports the base URL of the document it was cloned from. Fixes #454. Tests: web-platform-tests/wpt#61232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy a document's base URL when cloning
The baseURI getter now defers to a new "get the base URL" algorithm, which returns null by default and falls back to the node document's URL. HTML overrides this algorithm (to return the document base URL), so DOM no longer reaches into HTML for a value returned by a DOM API.
Cloning a document now copies its base URL into a new "base URL override", so that a shallow clone, which has no base element, still reports the base URL of the document it was cloned from.
Fixes #454.
Tests: web-platform-tests/wpt#61232
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff