Skip to content

Make HIDDeviceFilter.vendorId an unsigned short - #166

Merged
nondebug merged 1 commit into
whatwg:mainfrom
gregstoll:vendorId-short
Oct 30, 2026
Merged

nondebug merged 1 commit into
whatwg:mainfrom
gregstoll:vendorId-short

Conversation

@gregstoll

@gregstoll gregstoll commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #156

  • At least two implementers are interested (and none opposed):
    • Chromium
    • Gecko
  • Tests are written and can be reviewed and commented upon at:
    • (do not have web-platform-tests around HIDDeviceFilter)
  • Implementation bugs are filed:
    • Chromium: already matches Chromium behavior
    • Gecko: not implemented
    • WebKit: not implemented
  • MDN issue is filed: …
    • (MDN does not go into this level of detail)
  • The top of this comment includes a clear commit message to use.

Preview | Diff

@nondebug
nondebug self-requested a review October 30, 2026 11:03

@nondebug nondebug left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nondebug
nondebug merged commit 19ec1aa into whatwg:main Oct 30, 2026
1 check passed
@gregstoll
gregstoll deleted the vendorId-short branch October 30, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

vendorId should be unsigned short in HIDDeviceFilter

2 participants