-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UA stylesheet for <select> base appearance #10670
base: main
Are you sure you want to change the base?
Conversation
Discussion here: w3c/csswg-drafts#10857
source
Outdated
@@ -135710,6 +135711,93 @@ progress { appearance: auto; }</code></pre> | |||
|
|||
</div> | |||
|
|||
<!-- TODO should this go at the top of the section right below "the select element"? --> | |||
<p>The following styles are expected to apply to <code>select</code> elements when they are being | |||
rendered as a <span>drop-down box</span> with <span>base appearance</span>:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we define what base
computes to when it's a list box?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this iteration I'm not proposing supporting base appearance on list box rendering. In chromium, I am making it do the same thing as appearance:auto, and our plan to do forward compat is to add a CSS @supports rule when appearance:base is ready for list box rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nt1m have you had a chance to review this?
I just updated this PR to match the latest styles from the CSS issue. I'm not sure what we should say about properties that are supposed to be inherited, like color and font. Should we explicitly say color:inherit? Should we have some text which says that all properties not listed here should be whatever their unset value is? Should we just say that other UA styles should not apply? There is a bunch of UA styles in chromium I have to undo by adding extra CSS, and while I don't want to list all those properties specifically in this spec I also think it would be a good idea to mention that when implementing this feature, you have to undo those. |
I think we need to list all those properties explicitly in the spec! Why would we not? |
I think @josepharhar is describing Chromium's implementation of "base appearance", as in principle "base appearance" would start from an unstyled element so you would not have to undo styling, unless it was some global style. |
I see. That's probably covered by the CSS spec for |
Agreed! I'll omit the properties which have their default. |
This PR adds a stylesheet for customizable select which applies when the select element has base appearance.
Discussion here: w3c/csswg-drafts#10857
Customizable select proposal: #9799
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/rendering.html ( diff )