-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify WebDriver BiDi about "committed" navigations #10910
base: main
Are you sure you want to change the base?
Conversation
4ae7d44
to
cfad3b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cfad3b6
to
7641acb
Compare
So in 6.4.1 in attempt to populate the history entry's document (covering the case of navigating to a document without a DOM) seems to run a the navigation failed steps (and so emits a navigation failed event), but the document isn't null in that case so we'll still send the navigation committed event in 7.4. Possibly we need to move emitting this event up into step 6? |
Thanks for spotting this. On one hand there is a new document committed by the navigation (that might be relevant for the client), on the other hand the events get confusing (failed, then committed) and IIUC this is about error pages where the only useful action is to reload. I guess moving to 6 would be an option or checking saveExtraDocumentState or document's salvageable state. |
47c48ab
to
5ac7342
Compare
5ac7342
to
80caa5a
Compare
Moved to step 6. |
This PR adds integration with the WebDriver BiDi spec to notify automation sessions when a navigation results in a new document being loaded. See w3c/webdriver-bidi#788 and w3c/webdriver-bidi#855.
navigationCommitted
event to inform immediately about the navigation status w3c/webdriver-bidi#788(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/infrastructure.html ( diff )