Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to update radio button group checkedness when an input radio becomes connected #10917

Merged

Conversation

EdgarChen
Copy link
Member

@EdgarChen EdgarChen commented Jan 15, 2025

Closes #10897.

(See WHATWG Working Mode: Changes for more details.)


/input.html ( diff )

@EdgarChen
Copy link
Member Author

cc @domfarolino @annevk

@domfarolino domfarolino self-assigned this Jan 16, 2025
Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question: the issue mentions:

However, all browsers also update the checkedness state of elements in the same radio button group when the element becomes connected

But you also have an implementation bug filed for Firefox. Do any implementations need to do any work for this, or is this PR just bringing the spec inline with what all browsers do?

@EdgarChen
Copy link
Member Author

Our (Firefox) implementation bug is filed to align our behavior with other browsers for the case where a radio input is inserted into a disconnected radio group. Previously, we would also run the steps to update the checkedness state, but other browsers don’t. And this PR bring the spec inline with what all browsers do currently.

@domfarolino domfarolino merged commit a0050bd into whatwg:main Jan 30, 2025
2 checks passed
AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Jan 30, 2025
AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Jan 31, 2025
AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Feb 12, 2025
AtkinsSJ added a commit to LadybirdBrowser/ladybird that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Behavior of updating the checkedness state of the elements in the same radio button group is unclear
2 participants