Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change focus delegate for dialog to use flat tree to find focusable descendant #11088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change focus delegate for dialog to use flat tree to find focusable descendant #11088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81008,10 +81008,15 @@ dictionary <dfn dictionary>CommandEventInit</dfn> : <span>EventInit</span> {
<li><p>If <var>autofocusDelegate</var> is not null, then return
<var>autofocusDelegate</var>.</p></li>

<li>
<p>If <var>whereToLook</var> is a <code>dialog</code>, let <var>treeOrder</var> be the
<span>flat tree</span>. Otherwise, let <var>treeOrder</var> be <span>tree order</span>.</p>
</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below, format single-paragraph list items as <li><p>...</p></li>, without extra linebreaks/whitespace around the start/end tags. (Matching nearby style.)


<li>
<p><span data-x="list iterate">For each</span> <var>descendant</var> of
<var>whereToLook</var>'s <span data-x="descendant">descendants</span>, in <span>tree
order</span>:</p>
<var>whereToLook</var>'s <span data-x="descendant">descendants</span>, in
<var>treeOrder</var>:</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. We don't want to always look at the DOM tree descendants, just changing the order. We want to look at the flat tree descendants, which are different than the DOM tree descendants. (IIUC)


<ol>
<li><p>Let <var>focusableArea</var> be null.</p></li>
Expand Down Expand Up @@ -81053,9 +81058,14 @@ dictionary <dfn dictionary>CommandEventInit</dfn> : <span>EventInit</span> {
trigger</var> is given by the following steps:</p>

<ol>
<li>
<p>If <var>focus target</var> is a <code>dialog</code>, let <var>treeOrder</var> be the
<span>flat tree</span>. Otherwise, let <var>treeOrder</var> be <span>tree order</span>.</p>
</li>

<li>
<p>For each <span>descendant</span> <var>descendant</var> of <var>focus target</var>, in
<span>tree order</span>:</p>
<var>treeOrder</var>:</p>

<ol>
<li><p>If <var>descendant</var> does not have an <code
Expand Down