Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run FACE reset algorithm in "create an element for token" #11122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

domfarolino
Copy link
Member

@domfarolino domfarolino commented Mar 11, 2025

Fixes #10927. No browser implements "create an element for a token" > Step 13 fully. The reset algorithm is invoked, but NOT for form-associated custom elements, as tests indicate. This commit tightens the conditions under which we invoke the reset algorithm, to exclude form-associated custom elements, to match what browsers do.

(See WHATWG Working Mode: Changes for more details.)


/parsing.html ( diff )

@domfarolino domfarolino changed the title Stop running form-associated custom element reset algorithm in "create an element for token" Don't run form-associated custom element reset algorithm in "create an element for token" Mar 11, 2025
@domfarolino domfarolino changed the title Don't run form-associated custom element reset algorithm in "create an element for token" Don't run FACE reset algorithm in "create an element for token" Mar 11, 2025
@domfarolino domfarolino added topic: custom elements Relates to custom elements (as defined in DOM and HTML) topic: forms labels Mar 11, 2025
@domfarolino domfarolino marked this pull request as ready for review March 11, 2025 22:15
@domfarolino domfarolino requested a review from domenic March 11, 2025 22:15
@annevk
Copy link
Member

annevk commented Mar 11, 2025

This does stray a bit from the original goal of explaining behavior of form controls. It doesn't seem that useful per se, but I wonder if we want to at least briefly discuss this in a meeting to make the decision a bit more shared and intentional.

@domfarolino domfarolino added the agenda+ To be discussed at a triage meeting label Mar 11, 2025
@domfarolino
Copy link
Member Author

Sure. I added agenda+.

@annevk
Copy link
Member

annevk commented Mar 11, 2025

cc @whatwg/components

@domenic
Copy link
Member

domenic commented Mar 12, 2025

I tend to agree it's disappointing that nobody implemented this, and it would have been nice if they implemented it. I'm not sure it's worth the compat risk at this point though, so if we decide to go this direction, I'm OK with it.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agenda+ To be discussed at a triage meeting topic: custom elements Relates to custom elements (as defined in DOM and HTML) topic: forms
Development

Successfully merging this pull request may close these issues.

Reset algorithm doesn't work in form-associated custom elements
3 participants