-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run FACE reset algorithm in "create an element for token" #11122
base: main
Are you sure you want to change the base?
Conversation
This does stray a bit from the original goal of explaining behavior of form controls. It doesn't seem that useful per se, but I wonder if we want to at least briefly discuss this in a meeting to make the decision a bit more shared and intentional. |
Sure. I added agenda+. |
cc @whatwg/components |
I tend to agree it's disappointing that nobody implemented this, and it would have been nice if they implemented it. I'm not sure it's worth the compat risk at this point though, so if we decide to go this direction, I'm OK with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorially LGTM
Fixes #10927. No browser implements "create an element for a token" > Step 13 fully. The reset algorithm is invoked, but NOT for form-associated custom elements, as tests indicate. This commit tightens the conditions under which we invoke the reset algorithm, to exclude form-associated custom elements, to match what browsers do.
(See WHATWG Working Mode: Changes for more details.)
/parsing.html ( diff )