Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of beforematch event #11151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Mar 21, 2025

This PR improves a paragraph which talks about firing the beforematch event by making it reference the revealing algorithm which actually fires it. It also sets the bubbles attribute to true, which wasn't specified before.

Fixes #11150

In my opinion this is editorial, but the bubbling flag was not explicitly specified before. I thought that events bubble by default, but I couldn't find any text to prove it.

(See WHATWG Working Mode: Changes for more details.)


/interaction.html ( diff )

This PR improves a paragraph which talks about firing the beforematch
event by making it reference the revealing algorithm which actually
fires it. It also sets the bubbles attribute to true, which wasn't
specified before.

Fixes whatwg#11150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Clarify whether beforematch event bubbles or not
1 participant