-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Specify browser UI-initiated navigations better #11250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In particular, they have a null sourceDocument. We need to handle that in various places in the specification. Closes #9133.
cc @trflynn89 @shannonbooth :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This puts some pressure on Fetch getting its null client act together.
I will hold off on merging this until we have agreement that whatwg/fetch#1820 is the right way to fix the request's window. (For example, we might instead prefer callers to set it.) |
Implementation musings: Implementing this in LadybirdBrowser/ladybird#4515 caused one of my tests for the state of
Though navigating to about:blank causing all previous state to go kaput seems odd, it's not like anyone who isn't trying to stress test the browser would do that during normal operation, right? ... |
In particular, they have a null sourceDocument. We need to handle that in various places in the specification.
Closes #9133.
In addition to @domfarolino and @noamr, review from @ADKaster or other Ladybird folks who might have run into this would be much appreciated.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/infrastructure.html ( diff )