Fix upgrade particular elements within a document again #11261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CustomElementRegistry define() call starts upgrading elements, we need to make sure to only include those associated with the current registry. This has test coverage through WPT custom-elements/registries/CustomElementRegistry-upgrade.html. Fixes #11256.
annevk
added
the
topic: custom elements
domenic
approved these changes
Apr 28, 2025
|
I tried this out earlier this morning and it definitely helps a lot! I'm still getting some problems but I don't have time to investigate right now. I'll open other issues once I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a CustomElementRegistry define() call starts upgrading elements, we need to make sure to only include those associated with the current registry.
This has test coverage through WPT custom-elements/registries/CustomElementRegistry-upgrade.html.
Fixes #11256.
/custom-elements.html ( diff )