Editorial: use named variables for media-resource-specific text tracks #11293
+73
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
May 12, 2025
| @@ -37461,7 +37461,8 @@ interface <dfn interface>MediaError</dfn> { | |||
|
|
|||
| <dd> | |||
| <p>If the <span>media data</span> is <span>CORS-same-origin</span>, run the <span>steps to | |||
| expose a media-resource-specific text track</span> with the relevant data.</p> | |||
| expose a media-resource-specific text track</span> with the relevant data, | |||
| the <span>media resource</span> and the <span>media element</span>.</p> | |||
There was a problem hiding this comment.
Oxford comma. (Also wrapping doesn't look quite right.)
| <p>The <dfn>steps to expose a media-resource-specific text track</dfn> given | ||
| some relevant data <var>data</var>, | ||
| a <span>media element</span> <var>element</var>, and | ||
| a <span>media resource</span> <var>resource</var> are:</p> |
| text track rendering</span> appropriate for the format in question.</p> | ||
| <li><p>Set <var>track</var>'s <span data-x="text track list of cues">list of cues</span>'s | ||
| <span>rules for updating the text track rendering</span> to the rules appropriate for the format | ||
| in question.</p> |
There was a problem hiding this comment.
"for data's format" maybe? Or resoure? What is the difference between data and resource?
| <dd>The <span>text track in-band metadata track dispatch type</span> must be set to the value | ||
| of the Name header field. <ref>OGGSKELETONHEADERS</ref></dd> | ||
| <dd>Set <var>track</var>'s <span data-x="text track in-band metadata track dispatch | ||
| type">in-band metadata track dispatch type</span> to the value of the Name header field. |
There was a problem hiding this comment.
Where does the header come from?
Comment on lines
39985
to
39992
| <dd>Let the | ||
| first <code data-x="">stsd</code> box of the | ||
| first <code data-x="">stbl</code> box of the | ||
| first <code data-x="">minf</code> box of the | ||
| first <code data-x="">mdia</code> box of the | ||
| <span>text track</span>'s <code data-x="">trak</code> box in the | ||
| first <code data-x="">mdia</code> box of | ||
| <var>track</var>'s <code data-x="">trak</code> box in the | ||
| first <code data-x="">moov</code> box | ||
| of the file be the <i>stsd box</i>, if any. |
There was a problem hiding this comment.
I think we should add <p> elements to this <dd>.
| for the data.</p> | ||
| <li> | ||
| <p>Set <var>track</var>'s <span data-x="text track mode">mode</span> to the mode consistent | ||
| with the user's preferences and the requirements of the relevant specification for the data.</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This algorithm feels more readable to me using named variables rather than referring to the objects indirectly.
/media.html ( diff )