-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Build list of selectedcontent elements to clear #11891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR improves the "clear a select's non-primary selectedcontent elements" algorithm by making it create a list of selectedcontent elements to modify separately from modifying them in order to prevent the list of elements to change while iterating. Fixes whatwg#11880
|
@josepharhar it doesn't seem like the tests in https://chromium-review.googlesource.com/c/chromium/src/+/7128135 have made their way to WPT. Any reason this appears to be stalled? |
annevk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo nit, but the test needs sorting out.
Sorry, I will get it reviewed very soon |
This PR improves the "clear a select's non-primary selectedcontent elements" algorithm by making it create a list of selectedcontent elements to modify separately from modifying them in order to prevent the list of elements to change while iterating.
Fixes #11880
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )