-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Introduce customelementregistry global attribute #12000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ja-y-son
wants to merge
3
commits into
whatwg:main
Choose a base branch
from
ja-y-son:cer-attr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we did not spot this before, but this clashes directly with https://dom.spec.whatwg.org/#dom-element-customelementregistry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the attribute should be called something like
initialcustomelementregistry, this would also make it clearer that setting the attribute has no effect on the actualcustomElementRegistry.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attribute hasn't been out for too long so it's probably still not too late to change it. Perhaps mirroring what we have for
shadowrootcustomelementregistry, we can make this attributeelementcustomelementregistry. @annevk @Jamesernator thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer
initialcustomelementregistrytoelementcustomelementregistry. I kind of wonder if we could get away without the IDL reflection, though? It would be quite strange for the content attribute to not reflect, but maybe that's okay?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we've gone out of our way to reflect even the attributes on the
templateelement that would be very weird and I don't think we should do that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed this with colleagues and we're not sure about either
initialordefaultas the registry in principle doesn't change. How aboutscopedcustomelementregistrywithscopedCustomElementRegistryas the IDL member?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mixed feelings about
scopedcustomelementregistrybecause having this attribute does not mean the user cannot assign a global registry to it later on, but perhaps that's not really a concern. I'm okay with this option, though I'm still more favoringelementcustomelementregistrybecause it has almost identical capabilities asshadowrootcustomelementregistrybut on elements, so the naming mirroring can also make sense.